[Wasm] Specify the least valid pointer for wasm32 #39300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
78 tasks
WebAssembly doesn't reserve low addresses but without "extra inhabitants" of the pointer representation, runtime performance and memory footprint are worse. So assume that compiler driver uses wasm-ld and --global-base=1024 to reserve low 1KB.
kateinoigakukun
force-pushed
the
katei/wasm-least-valid-addr
branch
from
74e5f37 to
6fd3ae7
Compare
|
Hi @rjmccall, would you have a moment to take a look at this PR? |
|
I'd personally be happier with 4096 here (same as other Swift 32-bit platforms, minimizes the chance of unexpected dependencies you'll have to track down later). |
|
@swift-ci please smoke test |
|
@tbkka thanks, that's updated now. Do you think there's anything else to be done here for a review approval? |
|
@swift-ci Please test |
tbkka
approved these changes
May 24, 2022
|
Thank you for your review and follow-up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebAssembly doesn't reserve low addresses but without "extra inhabitants" of
the pointer representation, runtime performance and memory footprint are
worse. So assume that compiler driver uses wasm-ld and --global-base=1024 to
reserve low 1KB.