[IRGen] Put 'ret void' instead of unreachable for non swiftasync cc #39680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
preset=buildbot_incremental_linux_crosscompile_wasm |
This comment has been minimized.
This comment has been minimized.
78 tasks
|
@swift-ci Please smoke test |
If target doesn't support musttail (e.g. WebAssembly), the function passed to coro.end.async can return control back to the caller. So the frontend should emit 'ret void' instead of unreachable after the coro.end.async intrinsic call to allow such situation.
kateinoigakukun
force-pushed
the
katei/fix-ill-unreachable-coro-end
branch
from
c460835 to
671ce74
Compare
|
@swift-ci Please smoke test |
|
@swift-ci please smoke test macOS platform |
|
Gentle ping :) |
|
@swift-ci please smoke test and merge |
|
Actually, we shouldn't need the re-test here, since it's so isolated. |
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Dec 7, 2021
The change in 39680 impacts more than WebAssembly, but it did not update the tests for impacted targets.
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Dec 7, 2021
The change in 39680 impacts more than WebAssembly, but it did not update the tests for impacted targets. (cherry picked from commit 3df2531)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If target doesn't support musttail (e.g. WebAssembly, it's available only under feature flag), the function passed to coro.end.async can return control back to the caller.
So the frontend should emit 'ret void' instead of unreachable after the coro.end.async intrinsic call to allow such situation.
Detail investigation report is here: swiftwasm#3646