Always Import FieldDecls from Records #40760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we switched this path over to use lazy member loading, a subsequent commit introduced a check that members were canonical. In certain extremely twisty scenarios involving multiple modular frameworks pulling in non-modular headers, this check can fail which results in us silently dropping these members on the floor. It's ultimately correct to only pull in the canonical members, but real-world examples of "system" frameworks evading modularity diagnostics exist so this is strictly a regression. Drop the canonicity check for FieldDecls. rdar://86740970
|
@swift-ci test |
|
I have been trying for hours to get the stars to align to test for this and I have failed... |
|
Build failed |
DougGregor
approved these changes
Jan 7, 2022
|
@swift-ci please smoke test macOS |
|
@swift-ci smoke test |
|
Thank for you finding and fixing this. Silly me, thinking the world is as it should be. |
CodaFi
force-pushed
the
field-of-dreams
branch
from
de42505 to
0b4641d
Compare
|
@swift-ci smoke test |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we switched this path over to use lazy member loading, a
subsequent commit introduced a check that members were canonical. In
certain extremely twisty scenarios involving multiple modular frameworks
pulling in non-modular headers, this check can fail which results in us
silently dropping these members on the floor.
It's ultimately correct to only pull in the canonical members, but real-world
examples of "system" frameworks evading modularity diagnostics exist so this
is strictly a regression.
Drop the canonicity check for FieldDecls.
rdar://86740970