Turn off the GenericSignatureBuilder #42113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Requirement Machine has been enabled in 'verify' mode for a while, where we run both the GenericSignatureBuilder and Requirement Machine minimization algorithm and compare the results, with the GenericSignatureBuilder being used to emit diagnostics. Now, it's time to flip the flags to 'enabled' mode, where the GenericSignatureBuilder doesn't run at all, and the Requirement Machine emits diagnostics. This finally allows us to realize the correctness and performance gains from using the Requirement Machine. See https://forums.swift.org/t/the-requirement-machine-a-new-generics-implementation-based-on-term-rewriting/55601/9 for details. Correctness: - https://bugs.swift.org/browse/SR-7353 - https://bugs.swift.org/browse/SR-9595 - https://bugs.swift.org/browse/SR-10532 - https://bugs.swift.org/browse/SR-10752 - https://bugs.swift.org/browse/SR-11100 - https://bugs.swift.org/browse/SR-11532 - https://bugs.swift.org/browse/SR-11997 - https://bugs.swift.org/browse/SR-12120 - https://bugs.swift.org/browse/SR-12736 - https://bugs.swift.org/browse/SR-12980 - https://bugs.swift.org/browse/SR-13018 - https://bugs.swift.org/browse/SR-13491 - https://bugs.swift.org/browse/SR-13502 - https://bugs.swift.org/browse/SR-14484 - https://bugs.swift.org/browse/SR-14485 - https://bugs.swift.org/browse/SR-14659 - https://bugs.swift.org/browse/SR-14776 - https://bugs.swift.org/browse/SR-14917 - https://bugs.swift.org/browse/SR-15009 - https://bugs.swift.org/browse/SR-15790 - https://bugs.swift.org/browse/SR-15920 - rdar://25065503 - rdar://39225307 - rdar://44590919 - rdar://45957015 - rdar://50169558 - rdar://51068593 - rdar://52921168 - rdar://54394068 - rdar://55758433 - rdar://58455439 - rdar://59132837 - rdar://62894047 - rdar://64953119 - rdar://65015626 - rdar://65558829 - rdar://68084643 - rdar://68376692 - rdar://75329340 - rdar://76646764 - rdar://77683844 - rdar://77794156 - rdar://78233378 - rdar://78481510 - rdar://78643612 - rdar://80820294 - rdar://81276358 - rdar://81425392 - rdar://83308672 - rdar://83373331 - rdar://83848546 - rdar://83955123 - rdar://88514540 - rdar://89641532 - rdar://90264856 - rdar://90343419 Performance: - rdar://33654588 - rdar://47821930 - rdar://51908331 - rdar://59037195 - rdar://65131776 - rdar://73771235 - rdar://75188696 GSB crashes with no reduced test case that are likely fixed: - https://bugs.swift.org/browse/SR-4872 - rdar://32144681 - rdar://42376632 - rdar://46270030 - rdar://47199993 - rdar://48648900 - rdar://49535930 - rdar://49712445 - rdar://49712637 - rdar://49713096 - rdar://49713107 - rdar://60334839 - rdar://66593156 - rdar://68982368 - rdar://76706682 - rdar://77794745 - rdar://84724541
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please test source compatibility |
Contributor
|
I love that the source compat suite failed with an unexpected pass for SR-13190, which also seems fixed by this |
This was referenced Apr 2, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Requirement Machine has been running in 'verify' mode for a while, where we run both the GenericSignatureBuilder and Requirement Machine minimization algorithm and compare the results, with the GenericSignatureBuilder being used to emit diagnostics.
Now, it's time to flip the flags to 'enabled' mode, where the GenericSignatureBuilder doesn't run at all, and the Requirement Machine emits diagnostics. This finally allows us to realize the correctness and performance gains from using the Requirement Machine.
See https://forums.swift.org/t/the-requirement-machine-a-new-generics-implementation-based-on-term-rewriting/55601/ for details.
Resolves rdar://88134788.
Correctness:
Performance:
GSB crashes with no reduced test case that are likely fixed: