Update the README.md instructions for utils/update-checkout option. #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `--clone-via-ssh` to match the true option flag `--clone-with-ssh`.
Remove parameter options.SerializeAllSIL from call to writeSIL()
|
Seems to include unrelated changes. |
|
Includes some unrelated changes which have already been merged into apple/swift master (see #424). Should I close this pull request? |
|
One can prevent this by creating a separate branch for the PR. |
|
OK, I will close and re-open with an isolated change. |
|
Ok and maybe add the link https://github.com/apple/swift/blob/master/utils/update-checkout#L89 so the reviewers can more easily see that your change makes sense. Thanks. |
|
By the way, when you edit a file via the GitHub website, a new branch is created automatically. |
2 tasks
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
…-spm Use built libraries when running SPM builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the README.md instructions for utils/update-checkout option. Should read
--clone-with-ssh.