[ConstraintSystem] Extend availability check to cover unavailable ext… #58466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensions The solver used to check availability attribute on the declaration itself, a better approach is to go through `AvailableAttr::isUnavailable` because that also covers unavailable extensions. Resolves: rdar://92364955
|
@swift-ci please test |
|
@swift-ci please test |
hborla
approved these changes
Apr 27, 2022
|
There is an issue in availability checker that has been exposed by this change so I'm going to back it out from main and 5.7 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ensions
The solver used to check availability attribute on the declaration
itself, a better approach is to go through
AvailableAttr::isUnavailablebecause that also covers unavailable extensions.
Resolves: rdar://92364955