Eager specializer: Fix pre-specialization of imported code #58642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test |
We must no pre-specialize imported code (except if this was explicitly called for by the importing module). Therefore, don't pre-specialize `shared` definitions based on their pre-specialization attributes. Rather, only pre-specialize if the pre-specialization is called for using a `target: "theFunctionToSpecialize"` parameter. Run OnonePrespecializations before serialization so that module native functions are not yet marked `shared` and can be identified as native. rdar://92337361
aschwaighofer
force-pushed
the
fix_eager_specialization_of_shared_definitions
branch
from
fb885e6 to
bcf24e4
Compare
Contributor
Author
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must no pre-specialize imported code (except if this was explicitly
called for by the importing module).
Therefore, don't pre-specialize
shareddefinitions based on theirpre-specialization attributes.
Rather, only pre-specialize if the pre-specialization is called for
using a
target: "theFunctionToSpecialize"parameter.rdar://92337361