[SymbolGraph] Output custom attributes #61838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom attributes were being skipped as their attribute name started with a "_". Underscored attributes are typically unstable and thus shouldn't be printed, but "_" is not being used for that purpose in the case of "_custom". Rather than checking for "_" or "__", just use `UserInaccessible`. This property is used for attributes that shouldn't be shown to users in eg. completion/printing/etc. Resolves rdar://99029554.
Contributor
Author
|
@swift-ci please test |
bnbarham
commented
Oct 31, 2022
bnbarham
commented
Oct 31, 2022
Contributor
Author
|
@swift-ci please test macOS platform |
QuietMisdreavus
approved these changes
Nov 1, 2022
Contributor
QuietMisdreavus
left a comment
QuietMisdreavus
left a comment
There was a problem hiding this comment.
This is really nice, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom attributes were being skipped as their attribute name started with a "". Underscored attributes are typically unstable and thus shouldn't be printed, but "" is not being used for that purpose in the case of "_custom".
Rather than checking for "_" or "__", just use
UserInaccessible. This property is used for attributes that shouldn't be shown to users in eg. completion/printing/etc.Resolves rdar://99029554.