[CSE] Stack nest at OSSA lowering after inlining. #64005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSE inlines a portion of lazy property getters. Now that in OSSA `partial_apply [on_stack]`s are represented as owned values rather than stack locations, it is possible for their destroys to violate stack discipline. A direct lowering of the instructions to non-OSSA would violate stack nesting. Previously, when inlining during CSE, it was assumed that the callee maintained stack discipline. And, when inlining an OSSA function into a non-OSSA function, OSSA instructions were lowered directly. The result was that stack discipline could be violated when directly lowering callees with `partial_apply [on_stack]`s that violate stack discipline upon direct lowering. Here, when CSE inlining a lazy property getter in OSSA form into a function lowered out of OSSA form, stack nesting is fixed up.
Contributor
Author
|
@swift-ci please test |
atrick
reviewed
Mar 3, 2023
Contributor
atrick
left a comment
atrick
left a comment
There was a problem hiding this comment.
@nate-chandler looks great to me too.
Just an observation. It might be less bug prone for the inliner to do this work itself. For efficiency, we might then want fixNesting to work on a region rather than the whole function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSE inlines a portion of lazy property getters.
Now that in OSSA
partial_apply [on_stack]s are represented as owned values rather than stack locations, it is possible for their destroys to violate stack discipline. A direct lowering of the instructions to non-OSSA would violate stack nesting.Previously, when inlining during CSE, it was assumed that the callee maintained stack discipline. And, when inlining an OSSA function into a non-OSSA function, OSSA instructions were lowered directly. The result was that stack discipline could be violated when directly lowering callees with
partial_apply [on_stack]s that violate stack discipline upon direct lowering.Here, when CSE inlining a lazy property getter in OSSA form into a function lowered out of OSSA form, stack nesting is fixed up.