[CMake] Add lib to swift host libraries link directories #64409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our libraries have a `LC_LINKER_OPTION` for eg. `-lswiftLLVMJSON`. This is resolved (probably just based on the actual libswiftLLVMJSON.a added to the link command) by ld, but not by lld. Add in a link directory so that these libraries can be found.
bnbarham
requested review from
DougGregor,
ahoppen,
compnerd,
etcwilde and
rintaro
Contributor
Author
compnerd
approved these changes
Mar 16, 2023
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
This is fine as a workaround. We should introduce a flag to disable auto-linking :/.
etcwilde
approved these changes
Mar 16, 2023
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our libraries have a
LC_LINKER_OPTIONfor eg.-lswiftLLVMJSON. This is resolved (probably just based on the actual libswiftLLVMJSON.a added to the link command) by ld, but not by lld. Add in a link directory so that these libraries can be found.