Add the drop_deinit instruction
#65060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
his instruction is a marker for a following destroy instruction to suppress the call of the move-only type's deinitializer.
…gument This happens for address-only move-only types.
…eeded by a drop_deinit rdar://105798769
Contributor
Author
|
@swift-ci test |
Contributor
|
I am fine with this. |
atrick
reviewed
Apr 25, 2023
Contributor
atrick
left a comment
atrick
left a comment
There was a problem hiding this comment.
Thanks @eeckstein. Looks great!
| %1 = drop_deinit %0 : $T | ||
| // T must be a move-only type | ||
| // %1 is an @owned T | ||
| %3 = drop_deinit %2 : $*T |
Contributor
There was a problem hiding this comment.
@eeckstein do we need to support an address form for drop_deinit?
I really hope we don't need that! It's easy to misuse and hard to verify.
In the meantime, can you remove it from the docs?
If we need an address form, we should discuss whether that should be drop_deinit_addr. Generally, instructions should have fixed number and type of operands except in special cases. debug_value is an exception where it works out ok. But an instruction that produces a new address is not straightforward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
drop_deinitinstruction is a marker for a following destroy instruction to suppress the call of the move-only type's deinitializer.SILGen needs to insert
drop_deinitin move-only deinitializers to avoid that - due to other optimizations, like inlining - the deinitializer call is inserted multiple times.rdar://105798769