[cxx-interop] Add std::set initializer that takes a Swift Sequence
#65087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please test |
hyp
approved these changes
Apr 12, 2023
Contributor
hyp
left a comment
hyp
left a comment
There was a problem hiding this comment.
Nice, now we just need an insert as well :)
hyp
reviewed
Apr 12, 2023
hyp
reviewed
Apr 12, 2023
egorzhdan
force-pushed
the
egorzhdan/cxx-set-init
branch
from
2b96c27 to
bac1045
Compare
Contributor
Author
Oh good point! We'll need to decide on the return type though, so I'd prefer to add |
Contributor
Author
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-set-init
branch
from
bac1045 to
cad0475
Compare
Contributor
Author
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-set-init
branch
from
cad0475 to
c52dd01
Compare
Contributor
Author
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-set-init
branch
from
c52dd01 to
16add36
Compare
Contributor
Author
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-set-init
branch
from
16add36 to
ff703ca
Compare
Contributor
Author
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-set-init
branch
from
ff703ca to
7a49105
Compare
Contributor
Author
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-set-init
branch
from
7a49105 to
dd7e177
Compare
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got unblocked by #64897.
rdar://107909624