Skip to content

5.9: [AccessSummaryAnalysis] Look through moves in hasExpectedUsesOfNoEscapePartialApply. #65124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nate-chandler merged 1 commit into from
Apr 13, 2023
Merged

5.9: [AccessSummaryAnalysis] Look through moves in hasExpectedUsesOfNoEscapePartialApply. #65124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/SILOptimizer/Analysis/AccessSummaryAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,10 @@ static bool hasExpectedUsesOfNoEscapePartialApply(Operand *partialApplyUse) {
return llvm::all_of(cast<CopyValueInst>(user)->getUses(),
hasExpectedUsesOfNoEscapePartialApply);

case SILInstructionKind::MoveValueInst:
return llvm::all_of(cast<MoveValueInst>(user)->getUses(),
hasExpectedUsesOfNoEscapePartialApply);

case SILInstructionKind::IsEscapingClosureInst:
case SILInstructionKind::StoreInst:
case SILInstructionKind::DestroyValueInst:
Expand Down
16 changes: 16 additions & 0 deletions test/SILOptimizer/access_summary_analysis.sil
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,22 @@ bb0(%0 : $*Int, %1 : $*Int, %2 : $*Int):
return %9999 : $()
}

// Look through moves.
// CHECK-LABEL: @partialApplyFollowedByConvertFunctionWithMove
// CHECK-NEXT: ([modify], [], [read])
sil private [ossa] @partialApplyFollowedByConvertFunctionWithMove : $@convention(thin) (@inout_aliasable Int, @inout_aliasable Int, @inout_aliasable Int) -> () {
bb0(%0 : $*Int, %1 : $*Int, %2 : $*Int):
%3 = function_ref @hasThreeCapturesAndTakesArgument : $@convention(thin) (Int, @inout_aliasable Int, @inout_aliasable Int, @inout_aliasable Int) -> ()
%4 = partial_apply %3(%0, %1, %2) : $@convention(thin) (Int, @inout_aliasable Int, @inout_aliasable Int, @inout_aliasable Int) -> ()
%5 = convert_function %4 : $@callee_owned (Int) -> () to $@callee_owned (Int) -> @error Error
%6 = move_value %5 : $@callee_owned (Int) -> @error Error
%7 = function_ref @takesGuaranteedNoEscapeClosureTakingArgumentThrowing : $@convention(thin) (@guaranteed @callee_owned (Int) -> @error Error) -> ()
%8 = apply %7(%6) : $@convention(thin) (@guaranteed @callee_owned (Int) -> @error Error) -> ()
destroy_value %6 : $@callee_owned (Int) -> @error Error
%9999 = tuple ()
return %9999 : $()
}

sil @use : $@convention(thin) (@noescape @callee_guaranteed () -> ()) -> ()
sil @subject : $@convention(thin) (Builtin.Int64) -> ()

Expand Down