[cxx-interop] Do not emit IR for C++20 requires expr #65652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please test |
hyp
reviewed
May 4, 2023
lib/IRGen/GenClangDecl.cpp
Outdated
| @@ -119,6 +119,10 @@ class ClangDeclFinder | |||
| return true; | |||
| } | |||
|
|
|||
| bool TraverseRequiresExpr(clang::RequiresExpr *RE) { | |||
| return false; | |||
There was a problem hiding this comment.
Actually this should be true. if you return false the traversal exits early which will make us miss some symbols. Can you test that in your test? e.g. make your function call something else and make sure that's emitted
There was a problem hiding this comment.
Right, thanks for noticing this!
hyp
requested changes
May 4, 2023
egorzhdan
force-pushed
the
egorzhdan/cxx-requires-irgen
branch
from
8959f9f to
0974fca
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
hyp
approved these changes
May 4, 2023
egorzhdan
force-pushed
the
egorzhdan/cxx-requires-irgen
branch
from
0974fca to
95da9ea
Compare
|
@swift-ci please smoke test |
This fixes a compiler crash when emitting IR for a for-in loop over a C++ `std::vector` in C++20 mode. rdar://108810356
egorzhdan
force-pushed
the
egorzhdan/cxx-requires-irgen
branch
from
95da9ea to
21745e5
Compare
|
@swift-ci please smoke test |
hyp
reviewed
May 5, 2023
| @@ -0,0 +1,10 @@ | |||
| // RUN: %target-swiftxx-frontend -emit-ir -Xcc -std=gnu++20 -I %S/Inputs %s | %FileCheck %s | |||
| // | |||
| // REQUIRES: OS=macosx | |||
There was a problem hiding this comment.
Can you add a note saying why this needs macOS in C++ 20 mode . Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a compiler crash when emitting IR for a for-in loop over a C++
std::vectorin C++20 mode.rdar://108810356