Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cxx-interop] Explicitly disable -fmodules-local-submodule-visibility #65715

Merged
merged 1 commit into from
May 14, 2023

Conversation

egorzhdan
Copy link
Contributor

@egorzhdan egorzhdan commented May 5, 2023

Clang implicitly enables local submodule visibility when compiling in C++20 mode. ClangImporter does not support it, so let's disable it explicitly.

rdar://108959307 / resolves #65710

Clang implicitly enables local submodule visibility when compiling in C++20 mode. ClangImporter does not support it, so let's disable it explicitly.

rdar://108959307 / #65710
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label May 5, 2023
@egorzhdan egorzhdan requested a review from beccadax May 5, 2023 20:04
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan requested a review from artemcm May 12, 2023 16:15
@egorzhdan egorzhdan merged commit 3865b5d into main May 14, 2023
@egorzhdan egorzhdan deleted the egorzhdan/cxx-disable-local-visibility branch May 14, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cxx-interop] Name lookup failures in C++20 mode on Linux
3 participants