[cxx-interop] Itanium ABI C++ records should have address-only layout when they can't be passed in registers #65813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an't be passed in registers This ensures that a C++ record with only ObjC ARC pointers with trivial other members is passed by value in SIL Fixes swiftlang#61929
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
This needs further work... |
|
I will take a look, try this patch out and give my review soon. Thanks for looking at this @hyp! |
|
@swift-ci please test |
|
@swift-ci please test windows platform |
|
Ah the macOS failure was due to a test bug :D |
…t failure on macOS
|
@swift-ci please test macOS platform |
hyp
changed the title
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that a C++ record with only ObjC ARC pointers with trivial other members is passed by value in SIL
Fixes #61929
Additionally,
[cxx-interop] mark C++ classes with trivial_abi attribute as unavailable in Swift