[5.9🍒] account for errors importing ObjC method as async prop #65979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forgot to check for errors when importing an ObjC method as an async computed property. rdar://109377788 (cherry picked from commit f3c4996)
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci build toolchain |
artemcm
approved these changes
May 19, 2023
Contributor
artemcm
left a comment
artemcm
left a comment
There was a problem hiding this comment.
This seems like a sound minimal fix. 👍🏼
tbkka
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Description: Avoid crashing if the method import failed; as the
bodyParamswill be null in such a case.• Risk: Very Low. Only adds a defensive check and removes an unused variable.
• Original PR: #65937
• Reviewed By: pending
• Testing: done manually
• Resolves: rdar://109377788