Skip to content

[Diagnostics] Skip overloaded locations where all solutions have the same type #66035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

xedin
Copy link
Contributor

@xedin xedin commented May 19, 2023

If there are multiple overloads, let's skip locations that produce
the same type across all of the solutions, such location is most
likely a consequence of ambiguity and not its source.

Resolves: rdar://109245375

@xedin xedin requested a review from hborla as a code owner May 19, 2023 22:49
@xedin
Copy link
Contributor Author

xedin commented May 19, 2023

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented May 19, 2023

@swift-ci please test

…same type

If there are multiple overloads, let's skip locations that produce
the same type across all of the solutions, such location is most
likely a consequence of ambiguity and not its source.

Resolves: rdar://109245375
@xedin xedin force-pushed the rdar-109245375 branch from 79380e0 to f12e24e Compare May 20, 2023 19:09
@xedin
Copy link
Contributor Author

xedin commented May 20, 2023

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented May 20, 2023

@swift-ci please test macOS platform

Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@xedin
Copy link
Contributor Author

xedin commented Jun 16, 2023

@swift-ci please smoke test

@xedin xedin merged commit f8bde21 into swiftlang:main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants