Optimizer/IRGen: allow enums in static initializers of globals #66118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci benchmark |
…ction This comes up in the code for constructing an empty string literal. With this optimization it's possible to statically initialize empty string global variables.
Optimize the sequence ``` %1 = init_enum_data_addr %enum_addr, #someCaseWithPayload store %payload to %1 inject_enum_addr %enum_addr, #someCaseWithPayload ``` to ``` %1 = enum $E, #someCaseWithPayload, %payload store %1 to %enum_addr ``` This sequence of three instructions must appear in consecutive order. But usually this is the case, because it's generated this way by SILGen.
… in static initializers Instead of passing `IRGenFunction`, pass the `IRGenModule` and the `IRBuilder`. This makes enum creation not dependent on the presence of a function. NFC, just refactoring.
The main change here is in IRGen which needs to be able to emit constant enum values. Use `emitValueInjection` to create the enum constant. Usually this method creates code in the current function. But if all arguments to the enum are constant, the builder never has to emit an instruction. Instead it can constant fold everything and just returns the final constant. Also, create statically initialized let-globals as constant global (`constant` instead of `global`).
Contributor
Author
|
@swift-ci test |
Contributor
aschwaighofer
left a comment
aschwaighofer
left a comment
There was a problem hiding this comment.
The IRGen part looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change in this PR is in IRGen which needs to be able to emit constant enum values.
Use
emitValueInjectionto create the enum constant. Usually this method creates code in the current function. But if all arguments to the enum are constant, the builder never has to emit an instruction. Instead it can constant fold everything and just returns the final constant.This PR also contains a few other statically-initialized-global related improvements:
constantinstead ofglobal)init_enum_data_addrinstructionvalue_to_bridge_objectinstructionFor details see the commit messages.
rdar://26521135