Skip to content

Support required inits in @objcImpl #66262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

beccadax
Copy link
Contributor

@beccadax beccadax commented Jun 1, 2023

  • Allow required inits in @objcImpl extensions of a class’s main body
  • Validate that the presence or absence of a required modifier matches the imported header declaration.

Fixes rdar://110016760.

@beccadax beccadax requested a review from tshortli June 1, 2023 00:52
@beccadax
Copy link
Contributor Author

beccadax commented Jun 1, 2023

@swift-ci please smoke test

• Allow `required init`s in @objcImpl extensions of a class’s main body
• Validate that the presence or absence of a `required` modifier matches the imported header declaration.

Fixes rdar://110016760.
@beccadax beccadax force-pushed the your-implementation-is-required branch from 48f47e4 to b14c00d Compare June 1, 2023 20:21
@beccadax
Copy link
Contributor Author

beccadax commented Jun 1, 2023

@swift-ci please test

@xedin xedin removed their request for review June 13, 2023 17:30
@beccadax
Copy link
Contributor Author

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit 0d1095e into swiftlang:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants