[Backtracing][Linux] Include declarations for gettid() and tgkill(). #66487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older glibc doesn't include these. Nor does Musl, it seems. The previous fix put the gettid() declaration too far down the file. rdar://110417355
Contributor
Author
|
Explanation: The previous fix was right but in the wrong place in the file so we still had the problem. Also, @MaxDesiatov pointed out a problem with Musl which will probably also affect older glibc, so fix that at the same time. |
MaxDesiatov
approved these changes
Jun 9, 2023
Contributor
Author
|
@swift-ci Please test |
Contributor
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci Please test Windows platform |
nkcsgexi
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older glibc doesn't include these. Nor does Musl, it seems. The previous fix put the
gettid()declaration too far down the file.rdar://110417355