[move-only] Do not attempt to lazily deserialize the moveonly deinit table in IRGen. #66505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jckarter
approved these changes
Jun 9, 2023
|
@swift-ci test |
|
@swift-ci please Build Toolchain macOS Platform |
…table in IRGen. SIL Functions are serialized in canonical SIL before they have their final ABI adjusted for large function arguments. Large function argument ABI is adjusted to be indirect as part of the transition from canonical SIL to lowered SIL. This means that if we deserialize a function from another module in canonical SIL and attempt to call it in IRGen we will call it with the wrong ABI implying if we reference any fields of the type in the deinit we will most likely crash (among other potential issues). This patch fixes the issue by changing IRGen to not lazily deserialize the moveonly deinit table and its associated functions. Instead if we do not have our table already deserialized, we just call the function's deinit via the destroy value deinit table. rdar://110496872
gottesmm
force-pushed
the
pr-13b73601ca744f17bd595d547bdfa2b9bb4f0b1e
branch
from
4dc593d to
b2a52ff
Compare
|
@swift-ci test |
|
@swift-ci please Build Toolchain macOS Platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason to avoid this is if we attempt to lazily deserialize the moveonly deinit table, we may also attempt to deserialize a deinit function. This would result in us breaking the invariant that we no longer deserialize SILFunctions once we are in LoweredSIL.
If we fail to lazily deserialize, we instead just call the deinit via the destroy value witness of the type.
This only affects builds built with asserts enabled since llvm_unreachable is compiled out when NDEBUG is set.
rdar://110496872