🍒[cxx-interop] Avoid linker errors when calling a defaulted constructor #66595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a default constructor is declared, but does not have a body because it is defaulted (`= default;`), Swift did not emit the IR for it. This was causing linker error for types such as `std::map` in libstdc++ when someone tried to initialize such types from Swift. rdar://110638499 / resolves #61412 (cherry picked from commit b459fb5)
|
@swift-ci please test |
|
@swift-ci please test macOS |
DougGregor
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: When a default constructor is declared, but does not have a body because it is defaulted (
= default;), Swift did not emit the IR for it. This was causing linker error for types such asstd::mapin libstdc++ when someone tried to initialize such types from Swift.Scope: This adjusts the way default constructors are imported for C++ structs.
Risk: Low, this only has an effect when C++ interop is enabled.
rdar://110638499 / resolves #61412 (cherry picked from commit b459fb5)