Skip to content

[5.9][Build] Read all shell output as UTF-8 #66656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2023
Merged

[5.9][Build] Read all shell output as UTF-8 #66656

merged 1 commit into from
Jun 16, 2023

Conversation

bnbarham
Copy link
Contributor

  • Explanation: Windows CI has been failing as there seems to be non-ASCII output from running update-checkout sometimes. Read all output as UTF-8 and then encode it back into ASCII (replacing errors) as we've had issues with UTF-8 then being output to terminal in the past.
  • Scope: Builds
  • Risk: Low. This impacts build infrastructure, if everything builds then there shouldn't be any issues.
  • Original PR: [Build] Read all shell output as UTF-8 #66440

@bnbarham
[Build] Read all shell output as UTF-8
d9b896a 
Encodes the output back into ASCII as there's been issues with printing
UTF-8 in the past.

Resolves rdar://110412212.

(cherry picked from commit 02603e3)
@bnbarham bnbarham requested a review from a team as a code owner June 15, 2023 00:40
@bnbarham bnbarham changed the title [Build] Read all shell output as UTF-8 [5.9][Build] Read all shell output as UTF-8 Jun 15, 2023
@bnbarham bnbarham added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 labels Jun 15, 2023
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham
Copy link
Contributor Author

@swift-ci please build toolchain

@bnbarham bnbarham merged commit cb109dc into swiftlang:release/5.9 Jun 16, 2023
@bnbarham bnbarham deleted the cherry-sprinkle-utf8 branch June 16, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnbarham @DougGregor