[5.9🍒] require consume x for noncopyable pattern bindings since they're consuming #66774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsuming this was staged in as a warning initially but it was intended to be an error if it is not written so that we can move to a world where these pattern matches are done as a borrowing operation instead. rdar://110908714 (cherry picked from commit 36451ef)
|
@swift-ci please test |
tbkka
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Description: Turns a warning about needing to explicitly write
consumeinto an error so that we can make pattern bindings borrow by default in the future.• Risk: Low. It's turning a warning into an error so there's source breaking concerns, but it's simple to fix.
• Original PR: #66713
• Reviewed By: Joe Groff
• Testing: regression tests included
• Resolves: rdar://110908714