[interop][SwiftToCxx] ensure swift::Int and swift::UInt are usable in… #67290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
… generic context Fixes swiftlang#63452 (cherry picked from commit 85a431e)
hyp
force-pushed
the
eng/5.9/reverse-interop-swiftInt
branch
from
8023810 to
435d0a6
Compare
|
added missing test |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
DougGregor
approved these changes
Jul 13, 2023
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… generic context
Fixes #63452
(cherry picked from commit 85a431e)
swift::Intandswift::UInttype is not guaranteed to be covered by existing set of templates on all platforms. More specifically, on Darwin,swift::Int -> ptrdiff_t -> longdoes not have a corresponding type trait, aslongis not used forint64_t. In this case, we should add an explicit type trait forswift::Intandswift::UInt, to ensure that these types can be used in a generic context from C++ on Darwin.