[QoI] Cleanup AST after trying to shrink constraint system of invalid expression #6801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… expression Since `ConstraintSystem::shrink` is going to attempt to type-check sub-expressions separately it's essential to clean-up AST if constraint generation or solving of the such expressions fails, otherwise if such solving resulted in creation of implicit expression type variables might leak to the outside.
|
/cc @rudkx @slavapestov Second attempt which should make ASAN happy, the problem with original solution was that I overlooked that |
|
@swift-ci Please smoke test |
|
Thanks, @slavapestov! |
|
ASAN doesn't like this version either. Please fix or revert. (Github revert isn't working.) |
|
@slavapestov Any ideas why that might be happening? Another approach might be to use a function and just call it directly in two places where it returns true... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
ConstraintSystem::shrinkis going to attempt to type-checksub-expressions separately it's essential to clean-up AST if constraint
generation or solving of the such expressions fails, otherwise if
such solving resulted in creation of implicit expression type variables
might leak to the outside.