[CMake] Update host platform check for macro support #68224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please smoke test |
Member
Author
|
@swift-ci Please Build Toolchain Linux |
bnbarham
approved these changes
Aug 30, 2023
Contributor
bnbarham
left a comment
bnbarham
left a comment
There was a problem hiding this comment.
There's also the one or two if(darwin) else cases that we should fix up too
"Support Macros in Linux" patches was inconsistent with checking platforms. Some only checked 'LINUX' but some matches 'LINUX|ANDROID|OPENBSD|FREEBSD'. Although I don't have tested other platoforms than Linux at all, there's no reason to limit it to Linux. So use the consistent check to match 'LINUX|ANDROID|OPENBSD|FREEBSD'
rintaro
force-pushed
the
swift-swift-bsd
branch
from
ab33b54 to
8049922
Compare
Member
Author
|
@swift-ci Please smoke test |
Member
Author
|
@swift-ci Please Build Toolchain Linux |
Member
|
Should macros work on linux now? I tried downloading this toolchain from the CI and it still fails on Doug's macro examples repo: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #68082
"Support Macros in Linux" patches was inconsistent with checking platforms. Some only checked
LINUXbut some matchesLINUX|ANDROID|OPENBSD|FREEBSD. Although I don't have tested other platoforms than Linux at all, there's no reason to limit it to Linux. So use the consistent check to matchLINUX|ANDROID|OPENBSD|FREEBSD