[5.9][PreCheck] Filter out macro declarations from result set #68288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move logic from `ConstraintGenerator::visitOverloadedDeclRefExpr` to pre-check to avoid including macro declarations referenced without `#`. This means that pre-checking would synthesize `TypeExpr` in situations when there is a type reference that is shadowed by a stdlib macro. Resolves: swiftlang#67815 Resolves: rdar://114796811 (cherry picked from commit cf257aa)
Contributor
Author
|
@swift-ci please test |
hborla
approved these changes
Sep 1, 2023
Contributor
Author
|
@swift-ci please test Windows platform |
Contributor
Author
|
@swift-ci please build toolchain macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #68254
Move logic from
ConstraintGenerator::visitOverloadedDeclRefExprto pre-check to avoid including macro declarations referenced without
#.This means that pre-checking would synthesize
TypeExprin situationswhen there is a type reference that is shadowed by a stdlib macro.
Scope: Situations when project imports Foundation or Observation and another project i.e. RxSwift that has name slash with macro declaration.
Main Branch PR: [PreCheck] Filter out macro declarations from result set #68254
Resolves: rdar://114796811
Risk: Low
Reviewed By: @slavapestov
Testing: Added test-cases to the suite.
Resolves: #67815
Resolves: rdar://114796811
(cherry picked from commit cf257aa)