[swift-syntax] Don’t pass --filecheck-exec to swift-syntax’s build script
#68364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…script swift-syntax no longer has lit tests, so the `--filecheck-exec` parameter isn’t needed anymore.
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Sep 7, 2023
| 'bin', | ||
| 'FileCheck') | ||
| ]) | ||
| command='test') | ||
|
|
||
| def should_install(self, host_target): | ||
| return self.args.install_swiftsyntax |
There was a problem hiding this comment.
Are all the dependencies in get_dependencies actually needed?
There was a problem hiding this comment.
Yes, I think so. We might not need to list LLVM, LibCXX, LibICU and LLBuild because they are transitive dependencies of Swift / SwiftPM that we don’t explicitly depend upon but I’m not sure if get_dependencies should include these transitive dependencies.
@gottesmm You added these, do you know if we explicitly need to list these dependencies here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion of swiftlang/swift-syntax#2160
swift-syntax no longer has lit tests, so the
--filecheck-execparameter isn’t needed anymore.