Fix silent test failures on windows #68676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
approved these changes
Sep 21, 2023
Contributor
|
@swift-ci please test |
Contributor
|
Is this also happening on main then 🤔? |
Contributor
|
Contributor
|
I've included in #68692. @tristanlabelle could you put this up on main 🙏? |
Member
|
@bnbarham the MSI restructuring on main would explain why |
Member
|
@swift-ci please build toolchain Windows platform |
Contributor
|
I've cherry-picked this to the other 5.9 branch anyway @compnerd. Can close this one. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build was succeeding after test failures because
exit /bfrom within acallonly exits the subroutine, not the full script:We need to also bubble the error after the call returns.