[Distributed] Correct generic parameter handling in distributed func accessor (debug builds) #68859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
commented
Sep 29, 2023
ktoso
force-pushed
the
wip-generic-reqs-from-actor-da-for-accessor
branch
from
cb34c82 to
17e6ac3
Compare
ktoso
force-pushed
the
wip-generic-reqs-from-actor-da-for-accessor
branch
2 times, most recently
from
3729dca to
3af6777
Compare
|
Okey, this should be good to go now -- we don't actually want generics from the target on the accessor, but along the way we fixed how we handle the accessor signature somewhat. This has no wire impact, manglings remain the same -- just the accessor changed which isn't exposed externally. Testing all the confs is difficult for that so I expect a CI failure that I will follow up |
|
@swift-ci please test |
ktoso
changed the title
xedin
approved these changes
Oct 5, 2023
ktoso
force-pushed
the
wip-generic-reqs-from-actor-da-for-accessor
branch
from
3af6777 to
e09411f
Compare
|
@swift-ci please smoke test |
|
We landed a bunch of other fixes with #68517 so now this PR seems is all good. |
|
@swift-ci please smoke test |
|
Pending on #70057 to unbreak CI |
|
@swift-ci please smoke test hmm why is this failing on CI; lost the job need to re-run |
ktoso
force-pushed
the
wip-generic-reqs-from-actor-da-for-accessor
branch
from
6330df7 to
df2acf2
Compare
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-generic-reqs-from-actor-da-for-accessor
branch
from
df2acf2 to
e2d2ca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distributed func accessor does not need to carry forward generic parameters EXCEPT the Decoder and the self type. We adjust the implementation to pass those and correct handling of those parameters. This will now no longer produce crashes when distributed funcs are used in nested generic types in debug builds. This does not affect stable releases because those assertions are disabled there, and don't actually happen to cause issues here. But we should do the right thing in any case.
Resolves rdar://115497090
Resolves #68517
Old analysis:
If we don't do this, the generic parameter has no requirements at all, which a) is incorrect to begin with, it should have the exact same signature as the method it is the accessor for, and b) it would trip up verification which is enabled on linux in snapshot builds -- causing crashes.