[swift-vfe][swift-wme] Stop disabling function mergers for Swift VFE / WME #69407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ WME The Swift and LLVM function mergers were disabled when Swift VFE or WME are enabled because the function merger did not respect metadata on calls to `llvm.type.checked.load`. This is no longer the case, so we can turn these passes back on.
Contributor
Author
|
swiftlang/llvm-project#7679 @swift-ci Please test |
Contributor
Author
|
Linux failures look unrelated to me. |
Contributor
|
swiftlang/llvm-project#7679 @swift-ci test linux |
Contributor
Author
|
@eeckstein Do you mind merging / testing the LLVM side of things? swiftlang/llvm-project#7679. I can merge Swift. |
Contributor
|
I have merged the LLVM PR |
aschwaighofer
approved these changes
Oct 30, 2023
Contributor
|
@NuriAmari feel free to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Swift and LLVM function mergers were disabled when Swift VFE or WME are enabled because the function merger did not respect metadata on calls to
llvm.type.checked.load. This is no longer the case, so we can turn these passes back on.