🍒[5.10][Distributed] Don't crash in thunk generation when missing SR conformance #69502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
|
@swift-ci please test |
ktoso
force-pushed
the
pick-wip-dont-crash-missing-conformance-param
branch
from
924bbb9 to
3d47f70
Compare
|
@swift-ci please test |
|
@swift-ci please test |
ktoso
force-pushed
the
pick-wip-dont-crash-missing-conformance-param
branch
from
5ea3f0b to
ed25185
Compare
ktoso
force-pushed
the
pick-wip-dont-crash-missing-conformance-param
branch
from
ed25185 to
7cdeda7
Compare
|
@swift-ci please test |
|
Included another 1 line cleanup from #69901 |
|
@swift-ci please test |
DougGregor
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: We would properly diagnose the missing conformance; but the compiler would still try to emit a thunk for the errored func. Tests which only -typecheck -verify would not catch this issue because it is after type checking.
Solution: This prevents distributed thunks from being generated when the func they are based on already has errors -- otherwise we can run into missing types and null pointers as we try to generate the thunk.
Risk: Low, affects only this specific situation and just avoids emitting thunks when they cannot be correct to begin with -- when the funk is broken.
Impact: Only distributed functions; This provides a better failure path - rather than a crash, just the expected error reporting.
Review by: @xedin @slavapestov
Testing: CI testing
Original PR: #69501
Radar: rdar://116261701
Related radar: rdar://117677422