Enable SE-0413 "Typed Throws" by default #70677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
requested review from
hborla,
xedin,
slavapestov,
AnthonyLatsis,
ahoppen,
bnbarham,
CodaFi,
hamishknight and
rintaro
as code owners
|
@swift-ci please smoke test |
…artial solutions Failure to deduplicate potential throw sites could cause these data structures to grow expotentially. De-duplicate in the obvious way, noting that we still need an effective data structure here.
|
@swift-ci please smoke test |
Enabling typed throws has introduced some spurious warnings about error values of `Never` type on top of the custom "unreachable" diagnostics for catch clauses, so suppress the new warnings---they aren't helpful.
…erging partial solutions" This reverts commit 8e50528. We need more work on this part of the code.
DougGregor
force-pushed
the
se-0413-typed-throws
branch
from
b28b813 to
cde18d1
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test source compatibility |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature has been accepted, so enable it by default.