Skip to content

[NFC] Separate special builtin types into a lazily initialized vector #71249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

augusto2112
Copy link
Contributor

In preparation for future patches where debug info generation will need to access the special builtin types, lazily emit them into a separate lazily initialized vector.

@augusto2112
Copy link
Contributor Author

@swift-ci smoke test

@@ -1430,6 +1430,14 @@ class IRGenModule {
const char *getReflectionTypeRefSectionName();
const char *getMultiPayloadEnumDescriptorSectionName();

/// Returns the special builtin types that should be emitted in the stdlib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What makes these types "special" and sets them apart from other builtin types? Is this a techincal term used elsewhere, too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're "special" because they're always emitted in the stdlib, whereas other builtins may or may not be emitted.

In preparation for future patches where debug info generation will need
to access the special builtin types, lazily emit them into a separate
lazily initialized vector.
@augusto2112
Copy link
Contributor Author

@swift-ci smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants