Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Run executable tests with WasmKit #71309

Merged

Conversation

kateinoigakukun
Copy link
Member

This PR adds a new product, WasmKit, which is a Wasm runtime used for running executable tests. And also configures test suites to be run on CI.

Note that the product is not shipped as a part of the toolchain, but is used only for testing purposes.

@kateinoigakukun
Copy link
Member Author

preset=buildbot_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

@kateinoigakukun
Copy link
Member Author

preset=buildbot_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

@kateinoigakukun kateinoigakukun force-pushed the yt/runtime-tests-with-wasmkit branch from d77256b to ece7fd3 Compare February 2, 2024 05:50
@kateinoigakukun
Copy link
Member Author

preset=buildbot_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

@kateinoigakukun
Copy link
Member Author

I confirmed executable tests are now enabled on CI.

Before: https://ci.swift.org/job/swift-PR-Linux-preset/107/consoleFull

Testing Time: 3.83s
  Unsupported      : 541
  Passed           : 337
  Expectedly Failed:   3

After: https://ci.swift.org/job/swift-PR-Linux-preset/110/consoleFull

Testing Time: 35.48s
  Excluded         :   2
  Unsupported      : 684
  Passed           : 553
  Expectedly Failed:   4

@kateinoigakukun
Copy link
Member Author

@swift-ci Please smoke test

@kateinoigakukun kateinoigakukun force-pushed the yt/runtime-tests-with-wasmkit branch from ece7fd3 to 7e60170 Compare February 2, 2024 09:55
@kateinoigakukun
Copy link
Member Author

@swift-ci Please smoke test

@kateinoigakukun kateinoigakukun marked this pull request as ready for review February 2, 2024 12:09
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you so much!

#
# This source file is part of the Swift.org open source project
#
# Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the year?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, updated.

This patch adds a new product, WasmKit, which is a Wasm runtime that is
going to be used to run executable tests targeting Wasm. Note that the
product is not shipped as a part of the toolchain, but is used only for
testing purposes.
This patch allows running executable tests with WasmKit. If WasmKit is
not built, fall back to running only non-executable tests. Also add
stdlib and Concurrency executable tests to run.
This activates executable tests in addition to IRGen tests.
Those tests check so many input variations and take too long (hours) to
run. We can re-enable them once WasmKit is well optimized.
@kateinoigakukun kateinoigakukun force-pushed the yt/runtime-tests-with-wasmkit branch from 7e60170 to 8e0a79d Compare February 7, 2024 07:33
@kateinoigakukun
Copy link
Member Author

@swift-ci Please smoke test

@shahmishal shahmishal merged commit 9b06293 into swiftlang:main Feb 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants