IRGen: Mark async intrinsic helper functions as always inline #71414
Conversation
github.com/swiftlang/issues/68708 rdar://115905828
|
Please test with following PR: @swift-ci test |
adrian-prantl
left a comment
adrian-prantl
left a comment
There was a problem hiding this comment.
This looks fine from the debug info side!
| if (Level != OptimizationLevel::O0) | ||
| MPM.addPass(createModuleToFunctionPassAdaptor(SwiftARCContractPass())); | ||
| if (Level == OptimizationLevel::O0) | ||
| MPM.addPass(AlwaysInlinerPass()); |
There was a problem hiding this comment.
Are we sure this (the instance added by this PR) is the only place the alwaysinline attribute is used? Because by adding an optimization pass at O0 we might be changing more than what we intended to change.
There was a problem hiding this comment.
The default O0 llvm pass pipeline runs the AlwaysInlinerPass. Unfortunately just to early for our purposes i.e before Coro splitting.
There was a problem hiding this comment.
Got it, thanks for the clarification!
There was a problem hiding this comment.
Also, at least as far as debugging is concerned, inlining is a 100% "reversible" operation, i.e., it should be transparent in the debugger.
| if (Level != OptimizationLevel::O0) | ||
| MPM.addPass(createModuleToFunctionPassAdaptor(SwiftARCContractPass())); | ||
| if (Level == OptimizationLevel::O0) | ||
| MPM.addPass(AlwaysInlinerPass()); |
There was a problem hiding this comment.
Got it, thanks for the clarification!
3 participants
github.com//issues/68708
rdar://115905828