Add dependancy for Linux static-stdlib link argument files #7147
Conversation
|
@slavapestov This should fix the issue with the Driver/static_stdlib_linux_swift/ test. It would work on a clean compile but broke incremental builds |
|
@slavapestov @jckarter This is a CMakefile fix for the Driver/static_stdlib_linux_swift/ test bug Slava found . Could you take a quick look when you have time, thanks. |
|
Looks good, thanks! |
|
@swift-ci Please test |
| "${SWIFTSTATICLIB_DIR}/${linkfile}") | ||
| "${SWIFTSTATICLIB_DIR}/${linkfile}" | ||
| DEPENDS | ||
| "${SWIFT_SOURCE_DIR}/utils/${lowercase}/static-executable-args.lnk") |
There was a problem hiding this comment.
@spevans There is no ${lowercase} variable actually defined, so this always expands to the empty string. That matches up with the source tree, where static-executable-args.lnk is just a file in utils/, but may not be what you wanted.
There was a problem hiding this comment.
@rjmccall Ah - good spot! I will sort out a PR to remove this variable for now as its not needed.
Fix the makefiles to add the correct dependancies for the
static-executable-args.lnkandstatic-stdlib-args.lnkfiles.This broke incremental compiles if either of the source files was updated