#56350 - Give Identifier a hasUnderscoredNaming() helper #72048
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#56350
I gave Identifier a hasUnderscoredNaming() helper. Which is just:
I put it right under
hasDollarPrefix
figuring that made the most sense. I also replaced parts of the code usingstr().startsWith("_")
to use the new helper. I think the helper makes intention more clear and it is definitely more convenient (especially with code completion).I then reran swift/test:
There are 6 failures but these same tests always fail for me. I haven't looked too much into the failures (one is a module not being found, another is I am missing some python stuff) but I don't think they are related to the changes.