Skip to content

NCGenerics: update MakeAbstractConformanceForGenericType #72670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

NCGenerics: update MakeAbstractConformanceForGenericType #72670

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1df1982
NCGenerics: update `MakeAbstractConformanceForGenericType`
kavon Mar 28, 2024
0ef8041
NCGenerics: change notion of identity map
kavon Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/AST/TypeSubstitution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,15 @@ operator()(CanType dependentType, Type conformingReplacementType,
PackConformance::get(conformingPack, conformedProtocol, conformances));
}

// All conformances for invertible protocols are builtin, so they're already
// abstract in a sense.
if (conformedProtocol->getInvertibleProtocolKind()) {
auto &ctx = conformedProtocol->getASTContext();
return ProtocolConformanceRef(
ctx.getBuiltinConformance(conformingReplacementType, conformedProtocol,
BuiltinConformanceKind::Synthesized));
}

assert((conformingReplacementType->is<ErrorType>() ||
conformingReplacementType->is<SubstitutableType>() ||
conformingReplacementType->is<DependentMemberType>() ||
Expand Down