[6.0] modulewrap: Disable ObjC interop by default on non-Darwin platforms #73778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a5653d started to call `IGM.finalize()`, which leads the Clang instance to emit ObjC metadata sections when the ObjC interop is enabled. Emitting ObjC metadata sections is not well supported on non-Darwin platforms and causes crashes for WebAssembly and COFF object formats[^1]. modulewrap tool did not configure the ObjC interop option, so it always enabled the ObjC interop. This patch aligns the default ObjC interop value with other tools by disabling it on non-Darwin platforms. [^1]: https://github.com/apple/llvm-project/blob/stable/20230725/clang/lib/CodeGen/CGObjCMac.cpp#L5068-L5074
kateinoigakukun
added
🍒 release cherry pick
|
@swift-ci test |
|
@swift-ci test WebAssembly |
al45tair
approved these changes
May 22, 2024
|
@hborla For branch manager approval 🙏 |
bnbarham
approved these changes
May 29, 2024
|
Thanks @bnbarham! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes crash regression on modulewrap with WebAssembly target by disabling ObjC interop by default on non-Darwin platforms as swift-frontend does. The crash was introduced by #73371
Scope: Only affects non-Darwin platforms
Risk: Low; just applies the same ObjC interop availability rule to modulewrap as swift-frtonend does
Testing: CI testing
Reviewer: @MaxDesiatov
Original PR: #73440