[cxx-interop] Instantiate std::optional value constructors
#74146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
egorzhdan
force-pushed
the
egorzhdan/std-optional-init-value
branch
2 times, most recently
from
fcea468 to
c3b9880
Compare
Contributor
Author
|
@swift-ci please test |
egorzhdan
force-pushed
the
egorzhdan/std-optional-init-value
branch
2 times, most recently
from
bfb54e8 to
a2d7632
Compare
Contributor
Author
|
@swift-ci please smoke test |
1 similar comment
Contributor
Author
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/std-optional-init-value
branch
from
a2d7632 to
cd4f299
Compare
Contributor
Author
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/std-optional-init-value
branch
from
cd4f299 to
7404b98
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Linux |
4 similar comments
Contributor
Author
|
@swift-ci please test Linux |
Contributor
Author
|
@swift-ci please test Linux |
Contributor
Author
|
@swift-ci please test Linux |
Contributor
Author
|
@swift-ci please test Linux |
egorzhdan
force-pushed
the
egorzhdan/std-optional-init-value
branch
from
7404b98 to
c41a436
Compare
Contributor
Author
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/std-optional-init-value
branch
2 times, most recently
from
f70db4c to
50eb7c0
Compare
egorzhdan
force-pushed
the
egorzhdan/std-optional-init-value
branch
from
50eb7c0 to
8cf8a16
Compare
Contributor
Author
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/std-optional-init-value
branch
2 times, most recently
from
18ba265 to
2bf0bd3
Compare
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please build toolchain Ubuntu 22.04 |
Contributor
Author
|
The test failure on Ubuntu CI is not reproducible for me with Ubuntu 22.04 (slightly newer than the CI uses) and libstdc++-9 (same version as on CI). |
egorzhdan
force-pushed
the
egorzhdan/std-optional-init-value
branch
from
2bf0bd3 to
ca3b7ab
Compare
Contributor
Author
|
@swift-ci please test |
This improves support for initializing instances of `std::optional` from Swift. Previously only a null optional could be initialized directly from Swift. Now instantiations of `std::optional` will get a Swift initializer that takes the wrapped value as a parameter. rdar://118026392
egorzhdan
force-pushed
the
egorzhdan/std-optional-init-value
branch
from
ca3b7ab to
dcc3842
Compare
Contributor
Author
|
@swift-ci please test |
egorzhdan
requested review from
Xazax-hun,
beccadax,
fahadnayyar,
hnrklssn,
ian-twilightcoder,
j-hui,
susmonteiro and
zoecarver
as code owners
Xazax-hun
approved these changes
Jul 3, 2025
Contributor
Author
|
@swift-ci please test Windows |
1 similar comment
Contributor
Author
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves support for initializing instances of
std::optionalfrom Swift. Previously only a null optional could be initialized directly from Swift. Now instantiations ofstd::optionalwill get a Swift initializer that takes the wrapped value as a parameter.rdar://118026392