[SDK] Replace NSRange.toRange() with failable initialiser on Range<Int> #7446
Conversation
| // FIXME(ABI)#75 (Conditional Conformance): this API should be an extension on Range. | ||
| // Can't express it now because the compiler does not support conditional | ||
| // extensions with type equality constraints. | ||
| @available(*, deprecated, message: "Use Range(_: NSRange) initialiser instead") |
karwa
force-pushed
the
rangemaker
branch
2 times, most recently
from
0f37636 to
0845687
Compare
|
cc @phausler |
|
Please make sure to get review from someone from Foundation for changes in the overlay. |
|
Updated a comment on String.UTF16View Sure, I'll make sure to request a review from one of you next time :). I just happened to notice that this ABI FIXME was implementable now. |
|
pinging @phausler |
|
This is an API change and would make swift-corelibs deviate from the Darwin versions |
|
This is in the overlay, actually. I think we should consider it for post-Swift 4. |
|
The ABI FIXME led me to believe this source-breaking change was always planned when the requisite compiler features were available. It's just about when we force users to change their code. If the design is settled, I'd advocate for getting the "definitive" API out there as soon as possible. |
|
This pull request was opened 22 months ago. Is this still worth keeping open? There has been no movement here, and this PR cannot be merged as is into |
|
The bulk of this has been subsumed by the new |
Fixes ABI FIXME #75