[Macros] Fix memory leak #74941
Merged
[Macros] Fix memory leak #74941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `std::function` instance remained in memory. rdar://131048379
|
preset=buildbot_incremental_linux,lsan,tools=RDA,stdlib=DA,test=no |
|
@swift-ci Please smoke test |
|
OK this seems to be not enough... |
|
The same preset test in release/6.0 passed. So the remaining leaks seem to be unrelated. |
hamishknight
approved these changes
Jul 4, 2024
|
I just checked and the remaining leaks are also caused by #73725. LSAN passes fine before that PR was merged and all the failures started occurring after it was merged. |
|
@swift-ci Please smoke test |
|
This doesn't resolve all the leaks. But it does fix one leak, so I'm merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
std::functioninstance remained in memory.rdar://131048379