-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Typos: test/Interop
#75032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typos: test/Interop
#75032
Conversation
@swift-ci please test |
test/Interop/SwiftToC/functions/swift-primitive-functions-c-bridging.swift
Show resolved
Hide resolved
test/Interop/SwiftToC/functions/swift-primitive-functions-execution.c
Outdated
Show resolved
Hide resolved
test/Interop/SwiftToCxx/functions/swift-primitive-functions-cxx-bridging.swift
Outdated
Show resolved
Hide resolved
test/Interop/SwiftToC/functions/swift-primitive-functions-c-bridging.swift
Outdated
Show resolved
Hide resolved
@swift-ci please test |
@egorzhdan @AnthonyLatsis Sorry for downtime, I was on vacation, but back now. I've squashed and applied changes on top of main ( commit: 906efcb ) Anything I need to do to get this merged? |
@swift-ci please test |
See #75032 (comment). |
@swift-ci please smoke test |
See the logs. It appears the change in the symbol name also changed the relative order of its lowered definition in the checked output. |
Head branch was pushed to by a user without write access
@AnthonyLatsis I've put (Git diffs vs initial commit, added to the single commit) ![]() ![]() ![]() |
Looks good, thank you. Except, did |
@swift-ci please smoke test Linux |
OK, we’re green. If you could kindly exclude just that last change from the middle screenshot, I will wrap this up for you. |
Got it, fixing within the hour. The CI logs were deleted I think, so I could not see which files needed fixing. Or I just looked in the wrong place. |
@AnthonyLatsis I've reverted the changes to |
I meant just the last change, not a full reversion. The mangled name must be updated, but the permutation was unnecessary. Perhaps I was not clear enough, sorry. |
Ofc... silly me. The mangled name change should now be included in |
@swift-ci please smoke test |
@egorzhdan @zoecarver Is this good to go? |
@swift-ci please smoke test |
Fix typos in
test/Interop
This is one batch of many PRs fixing typos, see the tracking issue.