[6.0][Concurrency] Diagnose captures of self in a task created in deinit.
#75227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by diagnosing captures of `self` in escaping `sending` or `@Sendable` closures inside a deinit, which almost certainly means `self` will outlive deinit at runtime, which is a fatal error. This is a common mistake to make when creating isolated tasks inside nonisolated deinits to workaround the lack of synchrnous isolated deinits in Swift 6. (cherry picked from commit 18b747c)
|
@swift-ci please test |
|
Nice! |
DougGregor
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selfoutlivingdeinitcauses a fatal error at runtime. This is a common mistake to make when creating isolated tasks inside nonisolated deinits to workaround the lack of synchronous isolated deinits in Swift 6. This change adds a new compiler error, staged in as a warning in language modes prior to Swift 6 mode, when you captureselfin an@escapingclosure that's alsosendingor@Sendable, which covers both the task creation APIs as well asDispatchQueue.asyncwhen used directly inside adeinit.selfin an@escapingclosure that is alsosendingor@Sendableinside adeinit.selfin a task created indeinit. #75224.warnUntilSwiftVersion(6)