[6.0] @_extern is an experimental feature.
#75335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
|
|
Yeah, it was added in 6.0, so it shouldn't have had an opportunity to be used in production yet. It looks like it was originally implemented as an |
hborla
approved these changes
Jul 18, 2024
jckarter
force-pushed
the
extern-is-experimental-6.0
branch
from
ff09c9f to
596879d
Compare
|
@swift-ci Please test |
jckarter
force-pushed
the
extern-is-experimental-6.0
branch
from
596879d to
6fbefae
Compare
|
@swift-ci Please test |
Mark it as such. rdar://132013078
jckarter
force-pushed
the
extern-is-experimental-6.0
branch
from
6fbefae to
345e5a1
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
@_externwas accidentally enabled as a mainline feature even though it's experimental. This restores its experimental status.Scope: Bug fix.
Issue: rdar://132013078
Original PR: #75334
Risk: Low. Projects shouldn't be using
@_extern, but if they are, they have to-enable-experimental-feature Extern.Testing: Swift CI
Reviewer: @tshortli