[region-isolation] Emit an error when we assign a non-disconnected value into a sending result. #75351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
requested review from
eeckstein,
hborla,
jckarter,
ktoso,
slavapestov and
xedin
as code owners
|
@swift-ci smoke test |
…edIsolationInfo. Just slicing off a nice addition. These already had appropriate print methods so this commit just exposes the print API in the raw_ostream format.
…ue to compiler bugs, we have a function isolated to self without an isolated parameter. Closures generally only inherit actor instance isolation if they directly capture state from the actor instance. In this case, for some reason that is not true, so we hit an assert that assumes that we will only see a global actor isolated isolation. Region Isolation should be able to handle code even if the closure isolation invariant is violated by the frontend. So to do this, I am introducing a new singleton actor instance to represent the isolation of a defer or closure created in an actor instance isolated method. The reason why I am using a singleton is that closures and defer are not methods so we do not actually know which parameter is 'self' since it isn't in the abi. But we still need some value to represent the captured values as belonging to. To square this circle, I just did what we have done in a similar situation where we did not have a value: (ActorAccessorInit). In that case, we just use a sentinel to represent the instance (NOTE: This is represented just via a kind so ActorInstances that are operator== equal will not &value equal since we are just using a kind).
…PartitionUtils.h and add APIs for mapping an ElementID -> Representative. This is just moving up the declaration in the chain of dependencies so that I can write logic in PartitionUtils.h using it. I also added entrypoints to lookup the ReprensetativeValue for our various emitters.
… of just the representative of the source value when constructing assign and merge. This will let me know the exact source operand used instead of the source value representative. This will ensure that the name associated with the diagnostic is not of the representative value, but the actual value that was the source of the assign. This is an NFCI commit that is an algebraic refactor.
…lue into a sending result. rdar://127318392
|
@swift-ci smoke test |
…dingResult() so that the unittests can override it. The unittests for PartitionUtils pass in mocked operands and instructions that cannot be dereferenced. Adding this static CRTP helper allows for the unittest PartitionOpEvaluator subclass to just return false for it instead of dereferencing operands or instructions. The rest of the evaluators just get to use the default "normal" implementation that actually accesses program state.
ktoso
approved these changes
Jul 19, 2024
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://127318392