-
Notifications
You must be signed in to change notification settings - Fork 10.5k
SE-0441: Add language-mode option with alias to swift-version #75564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci test |
@dempseyatgithub could you please update a few tests to use new option so we can get some test coverage? |
000fa7a
to
5fd2eee
Compare
@swift-ci test |
@xedin I've added a few tests and the checks pass. I believe I've added the tests correctly. |
@dempseyatgithub could you please also open a PR to the swift-driver repo to update its options list according to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to tentatively approve this but let's merge this together with swift-driver changes @artemcm requested.
Generated with swiftlang/swift#75564 to include changes in PR to `Options.td` file.
I have opened a PR with this change: swiftlang/swift-driver#1686. Apologizes on having this taking so long, I seem to be a magnet for build issues. |
The swift-driver PR has passed its checks and been approved: |
swiftlang/swift-driver#1686 |
swiftlang/swift-driver#1686 |
swiftlang/swift-driver#1686 |
swiftlang/swift-driver#1686 |
The Swift Build Toolchain macOS Platform error seems to be a linking error that is not related to this change. @xedin Would the best approach be to rebase on top of main again and run the tests again?
|
@dempseyatgithub CI always rebases PRs on top of main so there is no need to do that. I'll try to figure out what is going on with toolchain. |
swiftlang/swift-driver#1686 |
swiftlang/swift-driver#1686 |
1 similar comment
swiftlang/swift-driver#1686 |
Tried with toolchain and it looks like everything works as expected! Thanks you, @dempseyatgithub! |
@swift-ci please smoke test |
Going to re-run smoke test just in case. |
You're welcome and thank you @xedin for all your help! |
As part of the implementation of SE-0441, this PR adds a compiler option
language-mode' with an alias to the existing
swift-version` option.