Skip to content

SE-0441: Add language-mode option with alias to swift-version #75564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

dempseyatgithub
Copy link
Contributor

As part of the implementation of SE-0441, this PR adds a compiler option language-mode' with an alias to the existing swift-version` option.

@dempseyatgithub
Copy link
Contributor Author

@swift-ci test

@xedin
Copy link
Contributor

xedin commented Aug 2, 2024

@dempseyatgithub could you please update a few tests to use new option so we can get some test coverage?

@dempseyatgithub
Copy link
Contributor Author

@swift-ci test

@dempseyatgithub
Copy link
Contributor Author

@dempseyatgithub could you please update a few tests to use new option so we can get some test coverage?

@xedin I've added a few tests and the checks pass. I believe I've added the tests correctly.

@artemcm
Copy link
Contributor

artemcm commented Aug 22, 2024

@dempseyatgithub could you please also open a PR to the swift-driver repo to update its options list according to:
https://github.com/swiftlang/swift-driver?tab=readme-ov-file#rebuilding-optionsswift

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to tentatively approve this but let's merge this together with swift-driver changes @artemcm requested.

dempseyatgithub added a commit to dempseyatgithub/swift-driver that referenced this pull request Aug 30, 2024
Generated with swiftlang/swift#75564 to include changes in PR to `Options.td` file.
@dempseyatgithub
Copy link
Contributor Author

@dempseyatgithub could you please also open a PR to the swift-driver repo to update its options list according to: https://github.com/swiftlang/swift-driver?tab=readme-ov-file#rebuilding-optionsswift

I have opened a PR with this change: swiftlang/swift-driver#1686.

Apologizes on having this taking so long, I seem to be a magnet for build issues.

@dempseyatgithub
Copy link
Contributor Author

The swift-driver PR has passed its checks and been approved:
swiftlang/swift-driver#1686

@xedin
Copy link
Contributor

xedin commented Aug 30, 2024

swiftlang/swift-driver#1686
@swift-ci please build toolchain macOS

@xedin
Copy link
Contributor

xedin commented Aug 30, 2024

swiftlang/swift-driver#1686
@swift-ci please test

@xedin
Copy link
Contributor

xedin commented Aug 30, 2024

swiftlang/swift-driver#1686
@swift-ci please test source compatibility

@dempseyatgithub
Copy link
Contributor Author

swiftlang/swift-driver#1686
@swift-ci please build toolchain macOS

@dempseyatgithub
Copy link
Contributor Author

The Swift Build Toolchain macOS Platform error seems to be a linking error that is not related to this change.

@xedin Would the best approach be to rebase on top of main again and run the tests again?

Undefined symbols for architecture arm64:
  "___isPlatformVersionAtLeast", referenced from:
      _$s20swift_willThrowTypeds19UTF8ValidationError33_03D0F4A7CE17AC628CBA43FDBE73E23FLLV_Tg5 in Swift.o
      _$ss26_stdlib_isOSVersionAtLeastyBi1_Bw_BwBwtF in Swift.o
      _$ss11AnySequenceV3mapySayqd__Gqd__xKXEKlFTm in Swift.o
      _$ss20_adHocPrint_unlocked___07isDebugC0yx_s6MirrorVq_zSbts16TextOutputStreamR_r0_lF13printTypeNameL_yyypXpsAER_r0_lF in Swift.o
      _$ss12validateUTF8ys0B16ValidationResultOSRys5UInt8VGF in Swift.o
      _$ss10repairUTF8_21firstKnownBrokenRangeSSSRys5UInt8VG_SnySiGtF in Swift.o
      _$ss12validateUTF8ys0B16ValidationResultOSRys5UInt8VGF4failL_yys0bC5Error33_03D0F4A7CE17AC628CBA43FDBE73E23FLLVYKF in Swift.o
      ...
ld: symbol(s) not found for architecture arm64

@xedin
Copy link
Contributor

xedin commented Sep 3, 2024

@dempseyatgithub CI always rebases PRs on top of main so there is no need to do that. I'll try to figure out what is going on with toolchain.

@xedin
Copy link
Contributor

xedin commented Sep 3, 2024

swiftlang/swift-driver#1686
@swift-ci please clean build toolchain macOS

@xedin
Copy link
Contributor

xedin commented Sep 3, 2024

swiftlang/swift-driver#1686
@swift-ci please build toolchain macOS

1 similar comment
@xedin
Copy link
Contributor

xedin commented Sep 4, 2024

swiftlang/swift-driver#1686
@swift-ci please build toolchain macOS

@xedin
Copy link
Contributor

xedin commented Sep 5, 2024

Tried with toolchain and it looks like everything works as expected! Thanks you, @dempseyatgithub!

@xedin
Copy link
Contributor

xedin commented Sep 5, 2024

@swift-ci please smoke test

@xedin
Copy link
Contributor

xedin commented Sep 5, 2024

Going to re-run smoke test just in case.

@dempseyatgithub
Copy link
Contributor Author

Going to re-run smoke test just in case.
Tried with toolchain and it looks like everything works as expected! Thanks you, @dempseyatgithub!

You're welcome and thank you @xedin for all your help!

@xedin xedin merged commit d53b1c4 into swiftlang:main Sep 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants